<html>
<head><meta charset="utf-8"><title>review #58281 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20.2358281.html">review #58281</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="180931205"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20%2358281/near/180931205" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20.2358281.html#180931205">(Nov 16 2019 at 22:35)</a>:</h4>
<p>Not sure if anyone other than estebank is capable of reviewing <a href="https://github.com/rust-lang/rust/pull/58281" target="_blank" title="https://github.com/rust-lang/rust/pull/58281">https://github.com/rust-lang/rust/pull/58281</a>, but it would be good to get some eyes on it and help <span class="user-mention" data-user-id="198054">@mark-i-m</span> out, as it's been waiting for a while now.</p>
<p><span class="user-mention" data-user-id="198054">@mark-i-m</span> -- I wonder if we could try to land some parts of it rather than the whole thing? It would probably be also be helpful for reviewers if you could update the top-level description with a summary of the current implementation status and errata (I note that <code>'_</code> handling in async/await is perhaps a not great 'patch' over the underlying problem, though it may be fine).</p>



<a name="180931252"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20%2358281/near/180931252" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20.2358281.html#180931252">(Nov 16 2019 at 22:36)</a>:</h4>
<p>I also wonder if at this point it makes sense to close and reopen the PR just to minimize GH history (188 comments is a <em>ton</em> even if a lot of them are bot generated and such)</p>



<a name="180931260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20%2358281/near/180931260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20.2358281.html#180931260">(Nov 16 2019 at 22:37)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="116083">@pnkfelix</span> <span class="user-mention" data-user-id="116009">@nikomatsakis</span> as T-compiler leads</p>



<a name="180941431"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20%2358281/near/180941431" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20.2358281.html#180941431">(Nov 17 2019 at 04:13)</a>:</h4>
<p>Hi, thanks <span class="user-mention" data-user-id="116122">@simulacrum</span> ! I updated the op with a description. Please let me know if I should add more detail</p>



<a name="180941480"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20%2358281/near/180941480" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20.2358281.html#180941480">(Nov 17 2019 at 04:14)</a>:</h4>
<p>Unfortunately I don't think it can be broken out more than it has already</p>



<a name="180941482"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20%2358281/near/180941482" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20.2358281.html#180941482">(Nov 17 2019 at 04:14)</a>:</h4>
<p>I can reopen if you want</p>



<a name="180957914"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20%2358281/near/180957914" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20.2358281.html#180957914">(Nov 17 2019 at 13:31)</a>:</h4>
<p>I will try to take another look today</p>



<a name="180977695"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20%2358281/near/180977695" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20.2358281.html#180977695">(Nov 17 2019 at 23:36)</a>:</h4>
<p>I am afraid I ran out of time today, hopefully will have time tomorrow though</p>



<a name="181142716"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20%2358281/near/181142716" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20.2358281.html#181142716">(Nov 19 2019 at 18:56)</a>:</h4>
<p>ugh I think I failed to give feedback on that one,  too, sorry <span class="user-mention" data-user-id="198054">@mark-i-m</span> for my part in it</p>



<a name="181174327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20%2358281/near/181174327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20.2358281.html#181174327">(Nov 20 2019 at 02:15)</a>:</h4>
<p>No worries. It was a large PR</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>